Previously POST /api/notes/:id/send used onConflictDoNothing on
(noteId, recipientUserId) and only iterated `inserted` rows for
side-effects, so a re-send to the same recipient was silent — no
note_received socket event, no notification — even though the API
returned 200. Reported by the user: "I sent again to rh, why
didn't it reach them?"
Fix: after the idempotent insert, load the existing recipient
rows for any recipients that were skipped, and run the
notification + socket emit loop over BOTH inserted and existing
rows. The DB row is still not duplicated (snapshot semantics
preserved), but the recipient now sees the popup and gets a fresh
notification on every re-send.
Verified:
- @workspace/api-server tests/notes-share.test.mjs — 12/12 pass
(including "re-sending to the same recipient does not duplicate
the recipient row").
- tx-os e2e notes-popup-on-receive — 3/3 pass.
Riyadh
e56fd9a6e3