Task: #177 — Make user/app/role deletion audit rows render readable
names ("Deleted user @alice (Alice Smith)", "Deleted app 'Notes'",
"Deleted role 'Editor'") instead of relying on whatever the route
happened to capture.
Backend metadata changes:
- artifacts/api-server/src/routes/users.ts (user.delete): now also
persists displayNameEn and displayNameAr alongside the existing
username/email.
- artifacts/api-server/src/routes/apps.ts (app.delete): renamed the
metadata keys slug/nameAr/nameEn → appSlug/appNameAr/appNameEn so
app sub-resource events and top-level deletes share one prefix.
- artifacts/api-server/src/routes/roles.ts (role.delete): renamed the
metadata key name → roleName, matching group.role.add/remove.
Frontend formatter (artifacts/tx-os/src/pages/admin.tsx):
- appName helper now reads both legacy (slug/nameEn/nameAr) and new
(appSlug/appNameEn/appNameAr) keys so old rows still render.
- role.delete case prefers roleName, falls back to legacy name.
- user.delete case picks the user's localized display name and uses
new locale strings user.deleteWithName / user.forceDeleteWithName
when present; falls back to the existing username-only strings.
- forceDeletedEntityName also accepts appNameEn/appNameAr/appSlug so
force-deleted apps still get their inline name chip.
Locales:
- artifacts/tx-os/src/locales/{en,ar}.json: added
admin.audit.summary.user.deleteWithName and forceDeleteWithName.
Test updates:
- artifacts/api-server/tests/audit-log-coverage.test.mjs: updated the
role.delete and app.delete (no-deps) assertions to read the new
metadata key names. The user.delete assertions kept working as-is
since username/email/force are unchanged.
No DB migration was required — audit_logs.metadata is already JSON.
Legacy rows continue to render via the formatter fallbacks called
out in the task description.
Riyadh
2c4655be31