rafraa/TX
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
0b7b571a1e3b72d33223a68de8baab4fdbdfda60
TX/pnpm-workspace.yaml
T
riyadhafraa 0b7b571a1e Task #108 — Executive Meetings Phase 2 (RBAC + audit + Zod + i18n) 
Schedule UI / shell:
- Centered cells, locked RTL column order # | الاجتماع | الحضور | الوقت,
  attendees column widest, tighter padding, navy/white/gray + red highlight only.
- Header label "م" → "#" (ar.json).

Schema (lib/db/src/schema/executive-meetings.ts):
- executive_meeting_requests.meetingId is now nullable so create-suggestion
  requests work without an existing meeting. db push applied.

Backend (artifacts/api-server/src/routes/executive-meetings.ts) — full rewrite:
- All routes (including /me) gated by requireExecutiveAccess. Fine-grained
  middleware: requireMutate / requireApprove / requireRequest /
  requireAdminAudit on the appropriate routes.
- Zod schemas validate every mutating body via parseBody().
- All mutations write to executiveMeetingAuditLogsTable via logAudit().
- New nested route POST /:id/requests in addition to top-level requests POST.
- Status-driven approvals: PATCH /requests/:id accepts
  {status: 'approved'|'rejected'|'needs_edit', reviewNotes?} or
  {action:'withdraw'} for the requester.
- PUT /font-settings (canonical) plus PATCH alias — both wired directly
  to the same shared upsertFontSettingsHandler (no method-rewrite hack).
- GET /tasks supports date and assigneeId filters.
- Removed all `as never` casts via $inferInsert/Partial typing.

Auth middleware (artifacts/api-server/src/middlewares/auth.ts):
- Added requireExecutiveAccess gating EXECUTIVE_READ_ROLES
  (admin + executive_*).

Frontend (artifacts/tx-os/src/pages/executive-meetings.tsx):
- Notifications visibility now uses canRead (was canViewAudit).
- Approvals: review() sends {status, reviewNotes} and a new
  "Send back for edits" (needs_edit) button is rendered alongside
  Approve/Reject.
- PdfSection: primary "Print + Archive" button (testid em-print) does
  archive then print in one click; em-print-only and em-archive remain.
- AuditSection: 6th column renders the new in-file AuditDiffSummary
  component (compact "field: old → new" diff with truncation).
- Print page (executive-meetings-print.tsx): kept its inline bilingual T
  table — it loads in a standalone print window before the i18n provider
  mounts, so an inline dictionary is the right pattern. No hardcoded UI
  text remains in the main page.

i18n (en.json + ar.json):
- New keys executiveMeetings.approvals.{needsEdit, needsEditDone},
  .audit.col.changes, .audit.{created, removed, moreChanges},
  .audit.entity.pdf_archive,
  .audit.action.{approved, rejected, needs_edit, withdraw, apply,
  duplicate, replace_attendees, done},
  .pdf.{print = "Print + archive"/"طباعة وأرشفة", printOnly,
  archivedAndPrinted}.

Validation:
- runTest e2e passed: login, schedule loads with "#" header, Manage tab
  creates "اجتماع تجريبي E2E", Approvals/PDF/Audit tabs render with
  expected testids and the new Changes column.
- curl smoke: login 200, /me 200, dates 200, create meeting 201,
  nested POST /:id/requests 201, PATCH /requests/:id status approval 200,
  audit-logs 200, DELETE meeting 204, PUT and PATCH /font-settings both
  200 with persisted data.
- Architect re-reviewed twice: VERDICT: APPROVED on the second pass
  after fixing /me gating and the PATCH font-settings dispatch.

Out of scope (handled in follow-ups #110/#111/#112): real notifications
delivery, server-side PDF rendering, mobile polish.

Drift: none material. Followed plan T1–T8.
2026-04-28 07:19:07 +00:00

126 lines
4.4 KiB
YAML
Raw Blame History

packages:
- artifacts/*
- lib/*
- lib/integrations/*
- scripts
autoInstallPeers: false
catalog:
'@replit/vite-plugin-cartographer': ^0.5.1
'@replit/vite-plugin-dev-banner': ^0.1.1
'@replit/vite-plugin-runtime-error-modal': ^0.0.6
'@tailwindcss/vite': ^4.1.14
'@tanstack/react-query': ^5.90.21
'@types/node': ^25.3.3
'@types/react': ^19.2.0
'@types/react-dom': ^19.2.0
'@vitejs/plugin-react': ^5.0.4
class-variance-authority: ^0.7.1
clsx: ^2.1.1
drizzle-orm: ^0.45.2
framer-motion: ^12.23.24
lucide-react: ^0.545.0
react: 19.1.0
react-dom: 19.1.0
tailwind-merge: ^3.3.1
tailwindcss: ^4.1.14
tsx: ^4.21.0
vite: ^7.3.2
zod: 3.25.76
minimumReleaseAge: 1440
minimumReleaseAgeExclude:
- '@replit/*'
- stripe-replit-sync
onlyBuiltDependencies:
- '@swc/core'
- esbuild
- msw
- unrs-resolver
overrides:
'@esbuild-kit/esm-loader': npm:tsx@^4.21.0
'@expo/ngrok-bin>@expo/ngrok-bin-darwin-arm64': '-'
'@expo/ngrok-bin>@expo/ngrok-bin-darwin-x64': '-'
'@expo/ngrok-bin>@expo/ngrok-bin-freebsd-ia32': '-'
'@expo/ngrok-bin>@expo/ngrok-bin-freebsd-x64': '-'
'@expo/ngrok-bin>@expo/ngrok-bin-linux-arm': '-'
'@expo/ngrok-bin>@expo/ngrok-bin-linux-arm64': '-'
'@expo/ngrok-bin>@expo/ngrok-bin-linux-ia32': '-'
'@expo/ngrok-bin>@expo/ngrok-bin-sunos-x64': '-'
'@expo/ngrok-bin>@expo/ngrok-bin-win32-ia32': '-'
'@expo/ngrok-bin>@expo/ngrok-bin-win32-x64': '-'
'@tailwindcss/oxide>@tailwindcss/oxide-android-arm64': '-'
'@tailwindcss/oxide>@tailwindcss/oxide-darwin-arm64': '-'
'@tailwindcss/oxide>@tailwindcss/oxide-darwin-x64': '-'
'@tailwindcss/oxide>@tailwindcss/oxide-freebsd-x64': '-'
'@tailwindcss/oxide>@tailwindcss/oxide-linux-arm-gnueabihf': '-'
'@tailwindcss/oxide>@tailwindcss/oxide-linux-arm64-gnu': '-'
'@tailwindcss/oxide>@tailwindcss/oxide-linux-arm64-musl': '-'
'@tailwindcss/oxide>@tailwindcss/oxide-linux-x64-musl': '-'
'@tailwindcss/oxide>@tailwindcss/oxide-win32-arm64-msvc': '-'
'@tailwindcss/oxide>@tailwindcss/oxide-win32-x64-msvc': '-'
esbuild: 0.27.3
esbuild>@esbuild/aix-ppc64: '-'
esbuild>@esbuild/android-arm: '-'
esbuild>@esbuild/android-arm64: '-'
esbuild>@esbuild/android-x64: '-'
esbuild>@esbuild/darwin-arm64: '-'
esbuild>@esbuild/darwin-x64: '-'
esbuild>@esbuild/freebsd-arm64: '-'
esbuild>@esbuild/freebsd-x64: '-'
esbuild>@esbuild/linux-arm: '-'
esbuild>@esbuild/linux-arm64: '-'
esbuild>@esbuild/linux-ia32: '-'
esbuild>@esbuild/linux-loong64: '-'
esbuild>@esbuild/linux-mips64el: '-'
esbuild>@esbuild/linux-ppc64: '-'
esbuild>@esbuild/linux-riscv64: '-'
esbuild>@esbuild/linux-s390x: '-'
esbuild>@esbuild/netbsd-arm64: '-'
esbuild>@esbuild/netbsd-x64: '-'
esbuild>@esbuild/openbsd-arm64: '-'
esbuild>@esbuild/openbsd-x64: '-'
esbuild>@esbuild/openharmony-arm64: '-'
esbuild>@esbuild/sunos-x64: '-'
esbuild>@esbuild/win32-arm64: '-'
esbuild>@esbuild/win32-ia32: '-'
esbuild>@esbuild/win32-x64: '-'
lightningcss>lightningcss-android-arm64: '-'
lightningcss>lightningcss-darwin-arm64: '-'
lightningcss>lightningcss-darwin-x64: '-'
lightningcss>lightningcss-freebsd-x64: '-'
lightningcss>lightningcss-linux-arm-gnueabihf: '-'
lightningcss>lightningcss-linux-arm64-gnu: '-'
lightningcss>lightningcss-linux-arm64-musl: '-'
lightningcss>lightningcss-linux-x64-musl: '-'
lightningcss>lightningcss-win32-arm64-msvc: '-'
lightningcss>lightningcss-win32-x64-msvc: '-'
rollup>@rollup/rollup-android-arm-eabi: '-'
rollup>@rollup/rollup-android-arm64: '-'
rollup>@rollup/rollup-darwin-arm64: '-'
rollup>@rollup/rollup-darwin-x64: '-'
rollup>@rollup/rollup-freebsd-arm64: '-'
rollup>@rollup/rollup-freebsd-x64: '-'
rollup>@rollup/rollup-linux-arm-gnueabihf: '-'
rollup>@rollup/rollup-linux-arm-musleabihf: '-'
rollup>@rollup/rollup-linux-arm64-gnu: '-'
rollup>@rollup/rollup-linux-arm64-musl: '-'
rollup>@rollup/rollup-linux-loong64-gnu: '-'
rollup>@rollup/rollup-linux-loong64-musl: '-'
rollup>@rollup/rollup-linux-ppc64-gnu: '-'
rollup>@rollup/rollup-linux-ppc64-musl: '-'
rollup>@rollup/rollup-linux-riscv64-gnu: '-'
rollup>@rollup/rollup-linux-riscv64-musl: '-'
rollup>@rollup/rollup-linux-s390x-gnu: '-'
rollup>@rollup/rollup-linux-x64-musl: '-'
rollup>@rollup/rollup-openbsd-x64: '-'
rollup>@rollup/rollup-openharmony-arm64: '-'
rollup>@rollup/rollup-win32-arm64-msvc: '-'
rollup>@rollup/rollup-win32-ia32-msvc: '-'
rollup>@rollup/rollup-win32-x64-gnu: '-'
rollup>@rollup/rollup-win32-x64-msvc: '-'
Reference in New Issue View Git Blame Copy Permalink