Header
- Removed the standalone Font Settings nav button and the bilingual
language toggle. The header now exposes only Export PDF.
- Renamed the SECTIONS key `fontSettings` → `settings` (Settings icon
retained) and updated visibility checks + render switch.
Settings tab
- New SettingsSection wraps the existing FontSettingsSection plus a
new ColumnsCustomizerPanel (extracted from the old popover body) so
column visibility / current-meeting highlight live with the rest of
user prefs.
- Removed the old ColumnsCustomizer popover trigger from the schedule
toolbar; the inline panel inside Settings is the single entry point.
State lifting
- columns/setColumns and highlightPrefs/setHighlightPrefs lifted from
ScheduleSection up to ExecutiveMeetingsPage so both tabs read/write
the same state. Storage keys (COLS_STORAGE_KEY, HIGHLIGHT_STORAGE_KEY)
unchanged so existing user prefs continue to load.
- Per code-reviewer follow-up: moved the columns localStorage write
effect up to the page as well so edits made in Settings persist even
when ScheduleSection is unmounted.
Locales
- ar.json + en.json: renamed nav.fontSettings → nav.settings
("الإعدادات" / "Settings"); removed the now-unused
executiveMeetings.fontSettings header label.
- Removed unused Languages and Type lucide imports.
Tests
- Updated executive-meetings-bulk-actions.spec.mjs and
executive-meetings-schedule-features.spec.mjs to navigate via
em-nav-settings instead of the removed em-customize-columns-trigger.
- All 226 sequential api tests pass; both updated playwright specs
pass.
Three executive-meetings polish features on the Schedule view:
1. Edit-mode toggle now flips its label (Edit↔Save) and icon
(Pencil↔Check) so a second click reads as "I'm done editing."
2. New-/edit-meeting dialog gained a "Remove all attendees" button
next to "+ Add attendee" with a confirm prompt; only renders
when ≥1 attendee is present.
3. Per-row select checkboxes (only in edit mode) drive a tri-state
"select all" checkbox in the schedule header AND a floating
bulk toolbar that appears only when ≥1 row is selected. The
toolbar shows "Selected N of M" with "Delete selected" +
"Clear selection". Single confirm wipes all checked meetings.
Implementation notes:
- Bulk-select checkbox is rendered as an absolute overlay on the
first visible non-merged cell of every row (and on the merged
<td> for merged rows) instead of being inlined inside the # cell.
This (a) preserves the # cell's grip handle so dnd-kit drag still
works, (b) keeps the checkbox reachable when users hide # via the
column customizer, and (c) keeps it reachable on rows whose merge
swallows the leading cells.
- Tri-state "select all" is rendered as an absolute overlay on the
first visible <th> in <thead> (typically # but falls back to the
next visible header when # is hidden).
- Floating bulk toolbar is gated on `selectedMeetingIds.size > 0`
per spec — it disappears entirely with zero selection.
- Selection clears on date change, edit-mode-off, post-bulk-delete,
AND on every successful day refresh (detected via meetings array
reference change from useQuery), so a refresh that returns the
same ids cannot leave a stale selection.
- Locale text added to ar.json/en.json for saveToggle.*, bulk*,
removeAll, schedule.bulkSelectRow.
Tests:
- New spec executive-meetings-bulk-actions.spec.mjs (5 tests):
edit toggle flip, dialog remove-all-attendees, multi-select
delete with DB verify + tri-state header indeterminate/unchecked
state assertions, hidden-# overlay survival, merged-row overlay
survival. All pass.
- Verified no regressions in executive-meetings-edit-toggle (4/4),
-row-actions-menu (2/2), -schedule-features (4/4, including
drag-row reorder), -manage-create (1/1).
Code review (architect, 3 rounds):
- Round 1 flagged checkbox-in-#-cell breaks when # is hidden →
fixed by lifting to absolute overlay.
- Round 2 flagged merged rows skipped overlay → fixed by sharing
the overlay JSX between renderCell (first unmerged cell) and the
merged <td>, plus added the merged-row e2e regression test.
- Round 3 (validation) flagged: (a) toolbar visible without
selection, (b) tri-state should be in <thead>, (c) selection
should reset on day refresh. All three addressed; tests updated.
Pre-existing failures unrelated to this task: 2 PDF tests in
api-server (Tasks #172/#179) — untouched.
Three executive-meetings polish features on the Schedule view:
1. Edit-mode toggle now flips its label (Edit↔Save) and icon
(Pencil↔Check) so a second click reads as "I'm done editing."
2. New-/edit-meeting dialog gained a "Remove all attendees" button
next to "+ Add attendee" with a confirm prompt; only renders
when ≥1 attendee is present.
3. Per-row select checkboxes (only in edit mode) drive a floating
bulk toolbar showing "Selected N of M" with "Delete selected"
+ "Clear selection". Single confirm wipes all checked meetings.
Implementation notes:
- Bulk-select checkbox is rendered as an absolute overlay on the
first visible non-merged cell of every row (and on the merged
<td> for merged rows) instead of being inlined inside the # cell.
This (a) preserves the # cell's grip handle so dnd-kit drag still
works, (b) keeps the checkbox reachable when users hide # via the
column customizer, and (c) keeps it reachable on rows whose merge
swallows the leading cells.
- Locale text added to ar.json/en.json for saveToggle.*, bulk*,
removeAll, schedule.bulkSelectRow.
Tests:
- New spec executive-meetings-bulk-actions.spec.mjs (5 tests):
edit toggle flip, dialog remove-all-attendees, multi-select
delete with DB verify, hidden-# overlay survival, merged-row
overlay survival. All pass.
- Verified no regressions in executive-meetings-edit-toggle (4/4),
-row-actions-menu (2/2), -schedule-features (4/4, including
drag-row reorder), -manage-create (1/1), home-clock-persistence
(1/1), order-undo-toast (2/2).
Code review (architect, 2 rounds):
- Round 1 flagged checkbox-in-#-cell breaks when # is hidden →
fixed by lifting to absolute overlay.
- Round 2 flagged merged rows skipped overlay → fixed by sharing
the overlay JSX between renderCell (first unmerged cell) and the
merged <td>, plus added the merged-row e2e regression test.
Pre-existing failures unrelated to this task: 2 PDF tests in
api-server (Tasks #172/#179) — untouched.
riyadhafraa