Task #446 made the Notes header `position: fixed` and added an
aria-hidden spacer below it sized to the header's measured height
(via ResizeObserver). The spacer was exactly the "big empty band"
the user kept seeing between the header bar and the
"اكتب ملاحظة..." composer — the page background gradient showed
through the reserved space.
Switched the header back to `sticky top-0 z-20`. Sticky keeps it
pinned to the top of the viewport while the page scrolls, but it
stays in document flow, so the composer renders immediately under
the bar with no artificial gap. Removed the now-unused
`headerRef`, `headerHeight` state, ResizeObserver effect, and the
spacer div. Bumped composer wrapper padding from `pt-1` back to
`pt-3` for a small breathing space (no longer competing with the
spacer).
No other changes; folders rail, composer behavior, RTL/LTR all
untouched.
The composer wrapper that sits directly under the fixed header's
height-matching spacer had `pt-4` (16px) on top, which made an obvious
empty band between the bottom border of the frozen header and the top
of the "اكتب ملاحظة..." card. Reduced that to `pt-1` (4px) so the
composer now sits flush under the bar with a minimal breathing space,
without affecting the rest of the page (folders rail / browser keep
their own `py-6`).
artifacts/tx-os/src/pages/notes.tsx:497 — single class change.
User wanted the Notes top bar to truly stay pinned (فريز / ثابت) while
scrolling, and wanted the "اكتب ملاحظة..." composer to live at the top
of the page above the folders area instead of being tucked under the
folders chips and only showing inside a folder.
Changes (artifacts/tx-os/src/pages/notes.tsx):
- Header bar switched from `sticky top-0` to `fixed top-0 inset-x-0
z-30`. Measured its live height with a `ResizeObserver` + `offsetHeight`
(header wraps differently per tab / label set / viewport width), and
rendered a same-height aria-hidden spacer immediately below so the
first row of content never slides under the bar.
- Composer was lifted out of the in-folder branch and is now rendered as
the first content block under the spacer (above FoldersRail and
FoldersBrowser) on the active "My Notes" view. It is hidden on Inbox,
Sent, Archived, and the Shared-with-me read-only folder view, so the
read-only contract from Task #445 stays intact. `folderSelection` is
still passed in unchanged, so a new note created from this top
composer continues to land in the currently-selected folder (or
Unfiled if none).
- Removed the duplicate Composer mount inside the per-folder branch and
left a comment explaining the move.
Notes:
- No backend or i18n changes — composer placeholder, search input, tabs,
label chips and grid/list toggle all kept their existing markup and
behavior.
- Pre-existing TS errors in artifacts/api-server/src/routes/executive-meetings.ts
remain (out of scope) and the `test` workflow continues to fail for
that unrelated reason.
Re-applied review fixes on top of the live folder-sharing implementation:
- PATCH/DELETE /notes/:id now do an id-only lookup and return an explicit
403 when the caller is not the owner (previously returned an ambiguous
404). This makes the read-only contract for shared-folder recipients
precise instead of silently masquerading as "not found".
- PUT /note-folders/:id/shares rejects self-share with 400
"Cannot share folder with yourself" instead of silently filtering the
caller's id out of the recipient set.
- GET /note-folders/shared-with-me now includes a `noteCount` (live count
of the owner's non-archived notes in the folder) computed via SQL
subquery; SharedFolder TS type updated; folders rail renders the count
next to each shared folder.
- SharedFolderView accepts the page's `search` value and filters the
read-only list client-side over title + content + checklist item text,
matching the owner's search experience. Empty state distinguishes
"no notes" from "no matches".
- Added GET /notes?sharedFolderId=:id as a spec-aligned alias that
returns the owner's live notes inside a folder shared with the caller
(gated by an active row in note_folder_shares).
- Updated the stale comment block above the share routes that claimed
recipient writes "just 404"; documents the new 403 contract.
Deviations / out of scope:
- Project uses `drizzle-kit push` (no migrations directory); no SQL
migration file was added.
- Pre-existing TS errors in artifacts/api-server/src/routes/executive-meetings.ts
remain; unrelated to Task #445.
- "Strict reject for nonexistent recipient ids in share PUT" left as
optional follow-up (currently silently dropped per existing behavior).
Owner can share a whole folder with other users; recipients see it
under "Shared with me" in the folders rail and view notes read-only
(cannot edit, add, move, or delete).
- DB: new noteFolderSharesTable (folderId/recipientUserId, cascade,
unique idx). Pushed via drizzle-kit.
- API (artifacts/api-server/src/routes/notes.ts):
- GET/PATCH/POST /note-folders return sharedWithCount.
- GET /note-folders/shared-with-me, GET /note-folders/:id/shares,
PUT /note-folders/:id/shares (idempotent diff), DELETE
/note-folders/:id/shares/:userId, GET /note-folders/:id/shared-notes
(verifies recipient via noteFolderSharesTable, stamps readOnly).
- Emits note-folder-shared / note-folder-unshared on share changes.
- Existing note write paths remain owner-scoped → recipients can't
mutate owner notes.
- Frontend types/hooks (notes-api.ts): SharedFolder, FolderShareRecipient,
SharedFolderNote/View; useFolderShares, useUpdateFolderShares,
useSharedWithMeFolders, useSharedFolderNotes.
- FoldersRail: Share menu item, sharedWithCount badge, "Shared with me"
section, "shared-folder" selection kind, onShareFolder prop.
- notes.tsx: SharedFolderView (no Composer, read-only cards using
ChecklistView), FolderShareDialog (seeds existing recipients,
idempotent PUT on save), revocation fallback effect, dialog mount.
- use-notifications-socket.ts: subscribe to note-folder-shared /
-unshared → invalidate shared-with-me + open shared-folder notes for
live rail/view refresh.
- i18n: AR/EN keys for share/sharedBy/sharedByName/sharedWithCount/
sharedWithMe/readOnly/shareRevoked/sharedEmpty/shareSaved/shareFailed.
Pre-existing failing `test` workflow (executive-meetings type errors)
is unrelated and out of scope.
Problem: the new-note composer in the Notes page only exposed Save —
to send a freshly-typed note the user had to save it, hover the
resulting card, and click the small Send icon. The user asked for an
explicit Send action right inside the composer and confirmed they're
fine with auto-saving as a side effect of pressing Send.
Implementation (artifacts/tx-os/src/pages/notes.tsx):
- Added `onSend: (id: number) => void` prop to <Composer> and wired
the NotesPage call site to forward to the existing
`setSendForNoteId(id)` flow that already mounts <SendNoteDialog>.
- Extracted a `buildPayload()` helper from save() so save() and the
new sendNew() use the exact same payload shape (title, content,
color, labels, kind, items, folderId).
- Added `sendNew()` that runs the same `create.mutate` save and, on
success, resets the composer and calls `onSend(created.id)` so the
send dialog opens for the freshly created note. On failure the
composer state is left intact (same UX as save() failures).
- Added a Send icon button next to Save inside the composer footer,
aria-labeled with the existing `notes.send` translation and tagged
`data-testid="notes-composer-send"`. The button is disabled while
the composer is empty (no title and no content/checklist text) and
while a create request is in flight to prevent duplicate notes
from rapid clicks.
The button lives inside the composer's `ref` so it doesn't trip the
existing click-outside-to-save handler, and <SendNoteDialog> renders
in a Radix portal which is already excluded from that handler.
No changes to send dialog logic, the per-card hover Send button, or
any other surface. tsc --noEmit passes for tx-os. The pre-existing
api-server `test` workflow failures (executive-meetings, service-
orders) are unrelated and out of scope.
Problem: in the Notes page header search field, the magnifier icon is
absolutely positioned on the start side (right in RTL, left in LTR)
via inline style, but the input's reserved padding was using
`isRtl ? "pe-9" : "ps-9"`. In RTL, `pe-9` resolves to padding-LEFT —
the opposite side from the icon — so the placeholder text "ابحث في
الملاحظات" started flush to the right edge and visibly overlapped
the icon. In LTR it happened to look correct because both `ps-9` and
the icon's `left: 10` line up.
Fix: pin the padding to the start side unconditionally
(`className="ps-9"`) so it always matches the icon's start-side
placement in both directions. Added an inline comment documenting
the invariant ("icon on start side ⇒ padding on start side") so a
future edit doesn't re-introduce the asymmetry.
Files:
- artifacts/tx-os/src/pages/notes.tsx (search input around line 304-321)
No behavioural changes to LTR rendering, no other search inputs
affected (only this one bound the padding to `isRtl`). Verified with
`pnpm exec tsc --noEmit` (clean). The pre-existing failing `test`
workflow stems from unrelated api-server tsc errors in
executive-meetings.ts and is out of scope for this task.
- artifacts/tx-os/src/lib/notes-api.ts: extended NOTE_COLORS so each
entry carries an `accent` Tailwind class alongside `bg`/`ring`
(default→amber, red→red, orange→orange, yellow→yellow, green→green,
teal→teal, blue→sky, purple→purple, pink→pink, gray→slate; all *-500
for visibility in light + dark). Added a `colorAccent(id)` helper
that resolves to a literal accent-* class, falling back to the
default amber for unknown/null ids. The class strings are written
out as literals so Tailwind v4's source scanner emits all of them
into the generated CSS — no dynamic class names, no safelist needed.
- artifacts/tx-os/src/pages/notes.tsx: ChecklistView gained an optional
`noteColor?: string | null` prop and now resolves its checkbox
accent via `colorAccent(noteColor)` instead of the hard-coded
`accent-amber-500`. Updated all four call sites (NoteCard, received
list, sent list, thread dialog) to pass `note.color` / `n.color` /
`thread.color`.
- artifacts/tx-os/src/components/notes/incoming-note-popup.tsx:
PopupChecklistPreview gained the same optional `noteColor` prop and
uses `colorAccent` for the checkbox className. Call site now passes
`current.color` from the popup queue.
- Unchecked boxes still render with the neutral browser default; only
the checked accent (the filled tint) follows the note color. The
default (white/card) note keeps amber for visibility against the
neutral surface in both themes.
- Verified: `pnpm exec tsc --noEmit` is clean and the
`tests/notes-popup-on-receive.spec.mjs` regression suite (incl. the
Task #433 checklist popup case) still passes 3/3.
- Pre-existing failing `test` workflow (api-server tsc errors in
executive-meetings.ts) is unrelated and out of scope.
- Rewrote artifacts/tx-os/src/lib/notification-sounds.ts to use the
Web Audio API (lazy AudioContext + decoded AudioBuffer cache) instead
of HTMLAudioElement. unlock() resumes the ctx for any non-running
state (handles iOS `interrupted`), plays a 1-sample silent buffer to
satisfy iOS Safari's gesture requirement, and pre-warms decodes.
decodeAudioData wrapped to support both Promise and callback forms
for older WebKit.
- play() dispatches an AUTOPLAY_BLOCKED_EVENT with `{ isIos }` detail
when ctx isn't running. Throttle is 3 s; new bypassThrottle option
(used by testPlay) skips the gate AND avoids advancing lastPlayAt
so settings previews can't suppress real socket chimes.
- use-audio-unlock.ts keeps gesture listeners attached and re-calls
unlock() on every gesture (handles iPad ctx auto-suspend on
background / AirPlay).
- use-autoplay-hint.ts reads detail.isIos and switches between
notifSettings.autoplayHint and notifSettings.autoplayHintIos
(added to en.json + ar.json with Control Center / silent-switch
guidance).
- notification-settings.tsx per-sound preview button now calls
notificationPlayer.testPlay(id).
- Test globals __txosNotifPlayCount/__txosNotifLastSound preserved;
added __txosNotifCtxState() accessor (dev/test-only, gated by
import.meta.env.MODE).
- Added tests/notification-sound-webaudio.spec.mjs covering the
preview button gesture path: counter increments, throttle bypass
works, singleton AudioContext reaches `running` state.
Notes:
- Pre-existing api-server tsc errors in executive-meetings.ts and the
failing `test` workflow are unrelated to this task and out of scope.
Backend
- New POST /notes/:id/checklist/:itemId/toggle endpoint. Owner or any
active (non-archived) recipient can flip an item's done flag.
- Wrapped in a DB transaction with SELECT ... FOR UPDATE on the live
note row so concurrent toggles from multiple collaborators can't
lose each other's updates. Live notes.items + every
note_recipients.items snapshot are mirrored atomically in the same
tx.
- Emits note_checklist_changed to the audience minus the actor with
the full updated items array so receivers can patch state without
an extra fetch.
Frontend
- useToggleChecklistItem mutation hook with optimistic updates across
notes/sent/received/thread caches and rollback on error.
- Incoming-note popup checklist is now interactive with a local
override for instant visual feedback (popup renders from socket
payload, not from the query cache).
- Thread checklist toggles are gated by effective permission (owner,
admin, or non-archived recipient) to mirror server auth.
- Socket handler for note_checklist_changed invalidates relevant
query keys AND patches the open popup payload directly via a new
IncomingNotePopupContext.updateChecklistItems action so
collaborators' open popups stay in sync.
Meeting alert animation parity (upcoming-meeting-alert.tsx)
- Added scale-95 -> scale-100 + fade entrance with the same spring
cubic-bezier the note popup uses, retriggered per eligible meeting.
- Replaced the 1px border with a ring-4 colored frame driven by
alertPrefs.accent (via boxShadow so the color is dynamic).
- Added an animate-ping accent halo around the drag-handle icon to
match the popup's avatar pulse.
Tests
- artifacts/api-server/tests/notes-checklist-toggle.test.mjs (7 tests:
owner/recipient toggle + mirroring, 403 non-recipient, 403
archived, 400 non-checklist, 404 unknown item, 400 invalid body).
- artifacts/tx-os/tests/notes-popup-checklist-collab.spec.mjs (e2e:
recipient ticks an item from the popup, server + sender snapshot
both reflect the change).
Code review (architect) findings addressed:
- (critical) lost-update race -> tx with row lock.
- (critical) non-atomic snapshot mirror -> same tx.
- (critical) open popup didn't re-render on socket fanout ->
updateChecklistItems context action.
- UI permission parity for archived recipients -> thread gates
onToggle.
Backend
- New POST /notes/:id/checklist/:itemId/toggle endpoint. Owner or any
active (non-archived) recipient can flip an item's done flag.
- Wrapped in a DB transaction with SELECT ... FOR UPDATE on the live
note row so concurrent toggles from multiple collaborators can't
lose each other's updates. Live notes.items + every
note_recipients.items snapshot are mirrored atomically in the same
tx.
- Emits note_checklist_changed to the audience minus the actor with
the full updated items array so receivers can patch state without
an extra fetch.
Frontend
- useToggleChecklistItem mutation hook with optimistic updates across
notes/sent/received/thread caches and rollback on error.
- Incoming-note popup checklist is now interactive with a local
override for instant visual feedback (popup renders from socket
payload, not from the query cache).
- Thread checklist toggles are gated by effective permission (owner,
admin, or non-archived recipient) to mirror server auth.
- Socket handler for note_checklist_changed invalidates relevant
query keys AND patches the open popup payload directly via a new
IncomingNotePopupContext.updateChecklistItems action so
collaborators' open popups stay in sync.
Meeting alert animation parity (upcoming-meeting-alert.tsx)
- Added scale-95 -> scale-100 + fade entrance with the same spring
cubic-bezier the note popup uses, retriggered per eligible meeting.
- Replaced the 1px border with a ring-4 colored frame driven by
alertPrefs.accent (via boxShadow so the color is dynamic).
- Added an animate-ping accent halo around the drag-handle icon to
match the popup's avatar pulse.
Tests
- artifacts/api-server/tests/notes-checklist-toggle.test.mjs (7 tests:
owner/recipient toggle + mirroring, 403 non-recipient, 403
archived, 400 non-checklist, 404 unknown item, 400 invalid body).
- artifacts/tx-os/tests/notes-popup-checklist-collab.spec.mjs (e2e:
recipient ticks an item from the popup, server + sender snapshot
both reflect the change).
Code review (architect) findings addressed:
- (critical) lost-update race -> tx with row lock.
- (critical) non-atomic snapshot mirror -> same tx.
- (critical) open popup didn't re-render on socket fanout ->
updateChecklistItems context action.
- UI permission parity for archived recipients -> thread gates
onToggle.
Backend
- New POST /notes/:id/checklist/:itemId/toggle endpoint. Owner or any
active (non-archived) recipient can flip an item's done flag.
- Wrapped in a DB transaction with SELECT ... FOR UPDATE on the live
note row so concurrent toggles from multiple collaborators can't
lose each other's updates. Live notes.items + every
note_recipients.items snapshot are mirrored atomically in the same
tx.
- Emits note_checklist_changed to the audience minus the actor with
the full updated items array so receivers can patch state without
an extra fetch.
Frontend
- useToggleChecklistItem mutation hook with optimistic updates across
notes/sent/received/thread caches and rollback on error.
- Incoming-note popup checklist is now interactive with a local
override for instant visual feedback (popup renders from socket
payload, not from the query cache).
- Thread checklist toggles are gated by effective permission (owner,
admin, or non-archived recipient) to mirror server auth.
- Socket handler for note_checklist_changed invalidates relevant
query keys AND patches the open popup payload directly via a new
IncomingNotePopupContext.updateChecklistItems action so
collaborators' open popups stay in sync.
Meeting alert animation parity (upcoming-meeting-alert.tsx)
- Added scale-95 -> scale-100 + fade entrance with the same spring
cubic-bezier the note popup uses, retriggered per eligible meeting.
- Replaced the 1px border with a ring-4 colored frame driven by
alertPrefs.accent (via boxShadow so the color is dynamic).
- Added an animate-ping accent halo around the drag-handle icon to
match the popup's avatar pulse.
Tests
- artifacts/api-server/tests/notes-checklist-toggle.test.mjs (7 tests:
owner/recipient toggle + mirroring, 403 non-recipient, 403
archived, 400 non-checklist, 404 unknown item, 400 invalid body).
- artifacts/tx-os/tests/notes-popup-checklist-collab.spec.mjs (e2e:
recipient ticks an item from the popup, server + sender snapshot
both reflect the change).
Code review (architect) findings addressed:
- (critical) lost-update race -> tx with row lock.
- (critical) non-atomic snapshot mirror -> same tx.
- (critical) open popup didn't re-render on socket fanout ->
updateChecklistItems context action.
- UI permission parity for archived recipients -> thread gates
onToggle.
Backend
- New POST /notes/:id/checklist/:itemId/toggle endpoint. Owner or any
active (non-archived) recipient can flip an item's done flag.
- Wrapped in a DB transaction with SELECT ... FOR UPDATE on the live
note row so concurrent toggles from multiple collaborators can't
lose each other's updates. Live notes.items + every
note_recipients.items snapshot are mirrored atomically in the same
tx.
- Emits note_checklist_changed to the audience minus the actor with
the full updated items array so receivers can patch state without
an extra fetch.
Frontend
- useToggleChecklistItem mutation hook with optimistic updates across
notes/sent/received/thread caches and rollback on error.
- Incoming-note popup checklist is now interactive with a local
override for instant visual feedback (popup renders from socket
payload, not from the query cache).
- Thread checklist toggles are gated by effective permission (owner,
admin, or non-archived recipient) to mirror server auth.
- Socket handler for note_checklist_changed invalidates relevant
query keys AND patches the open popup payload directly via a new
IncomingNotePopupContext.updateChecklistItems action so
collaborators' open popups stay in sync.
Meeting alert animation parity (upcoming-meeting-alert.tsx)
- Added scale-95 -> scale-100 + fade entrance with the same spring
cubic-bezier the note popup uses, retriggered per eligible meeting.
- Replaced the 1px border with a ring-4 colored frame driven by
alertPrefs.accent (via boxShadow so the color is dynamic).
- Added an animate-ping accent halo around the drag-handle icon to
match the popup's avatar pulse.
Tests
- artifacts/api-server/tests/notes-checklist-toggle.test.mjs (7 tests:
owner/recipient toggle + mirroring, 403 non-recipient, 403
archived, 400 non-checklist, 404 unknown item, 400 invalid body).
- artifacts/tx-os/tests/notes-popup-checklist-collab.spec.mjs (e2e:
recipient ticks an item from the popup, server + sender snapshot
both reflect the change).
Code review (architect) findings addressed:
- (critical) lost-update race -> tx with row lock.
- (critical) non-atomic snapshot mirror -> same tx.
- (critical) open popup didn't re-render on socket fanout ->
updateChecklistItems context action.
- UI permission parity for archived recipients -> thread gates
onToggle.
Backend
- New POST /notes/:id/checklist/:itemId/toggle endpoint. Owner or any
active (non-archived) recipient can flip an item's done flag.
- Wrapped in a DB transaction with SELECT ... FOR UPDATE on the live
note row so concurrent toggles from multiple collaborators can't
lose each other's updates. Live notes.items + every
note_recipients.items snapshot are mirrored atomically in the same
tx.
- Emits note_checklist_changed to the audience minus the actor with
the full updated items array so receivers can patch state without
an extra fetch.
Frontend
- useToggleChecklistItem mutation hook with optimistic updates across
notes/sent/received/thread caches and rollback on error.
- Incoming-note popup checklist is now interactive with a local
override for instant visual feedback (popup renders from socket
payload, not from the query cache).
- Thread checklist toggles are gated by effective permission (owner,
admin, or non-archived recipient) to mirror server auth.
- Socket handler for note_checklist_changed invalidates relevant
query keys AND patches the open popup payload directly via a new
IncomingNotePopupContext.updateChecklistItems action so
collaborators' open popups stay in sync.
Meeting alert animation parity (upcoming-meeting-alert.tsx)
- Added scale-95 -> scale-100 + fade entrance with the same spring
cubic-bezier the note popup uses, retriggered per eligible meeting.
- Replaced the 1px border with a ring-4 colored frame driven by
alertPrefs.accent (via boxShadow so the color is dynamic).
- Added an animate-ping accent halo around the drag-handle icon to
match the popup's avatar pulse.
Tests
- artifacts/api-server/tests/notes-checklist-toggle.test.mjs (7 tests:
owner/recipient toggle + mirroring, 403 non-recipient, 403
archived, 400 non-checklist, 404 unknown item, 400 invalid body).
- artifacts/tx-os/tests/notes-popup-checklist-collab.spec.mjs (e2e:
recipient ticks an item from the popup, server + sender snapshot
both reflect the change).
Code review (architect) findings addressed:
- (critical) lost-update race -> tx with row lock.
- (critical) non-atomic snapshot mirror -> same tx.
- (critical) open popup didn't re-render on socket fanout ->
updateChecklistItems context action.
- UI permission parity for archived recipients -> thread gates
onToggle.
Backend
- New POST /notes/:id/checklist/:itemId/toggle endpoint. Owner or any
active (non-archived) recipient can flip an item's done flag.
- Wrapped in a DB transaction with SELECT ... FOR UPDATE on the live
note row so concurrent toggles from multiple collaborators can't
lose each other's updates. Live notes.items + every
note_recipients.items snapshot are mirrored atomically in the same
tx.
- Emits note_checklist_changed to the audience minus the actor with
the full updated items array so receivers can patch state without
an extra fetch.
Frontend
- useToggleChecklistItem mutation hook with optimistic updates across
notes/sent/received/thread caches and rollback on error.
- Incoming-note popup checklist is now interactive with a local
override for instant visual feedback (popup renders from socket
payload, not from the query cache).
- Thread checklist toggles are gated by effective permission (owner,
admin, or non-archived recipient) to mirror server auth.
- Socket handler for note_checklist_changed invalidates relevant
query keys AND patches the open popup payload directly via a new
IncomingNotePopupContext.updateChecklistItems action so
collaborators' open popups stay in sync.
Meeting alert animation parity (upcoming-meeting-alert.tsx)
- Added scale-95 -> scale-100 + fade entrance with the same spring
cubic-bezier the note popup uses, retriggered per eligible meeting.
- Replaced the 1px border with a ring-4 colored frame driven by
alertPrefs.accent (via boxShadow so the color is dynamic).
- Added an animate-ping accent halo around the drag-handle icon to
match the popup's avatar pulse.
Tests
- artifacts/api-server/tests/notes-checklist-toggle.test.mjs (7 tests:
owner/recipient toggle + mirroring, 403 non-recipient, 403
archived, 400 non-checklist, 404 unknown item, 400 invalid body).
- artifacts/tx-os/tests/notes-popup-checklist-collab.spec.mjs (e2e:
recipient ticks an item from the popup, server + sender snapshot
both reflect the change).
Code review (architect) findings addressed:
- (critical) lost-update race -> tx with row lock.
- (critical) non-atomic snapshot mirror -> same tx.
- (critical) open popup didn't re-render on socket fanout ->
updateChecklistItems context action.
- UI permission parity for archived recipients -> thread gates
onToggle.
Backend
- New POST /notes/:id/checklist/:itemId/toggle endpoint. Owner or any
active (non-archived) recipient can flip an item's done flag.
- Wrapped in a DB transaction with SELECT ... FOR UPDATE on the live
note row so concurrent toggles from multiple collaborators can't
lose each other's updates. Live notes.items + every
note_recipients.items snapshot are mirrored atomically in the same
tx.
- Emits note_checklist_changed to the audience minus the actor with
the full updated items array so receivers can patch state without
an extra fetch.
Frontend
- useToggleChecklistItem mutation hook with optimistic updates across
notes/sent/received/thread caches and rollback on error.
- Incoming-note popup checklist is now interactive with a local
override for instant visual feedback (popup renders from socket
payload, not from the query cache).
- Thread checklist toggles are gated by effective permission (owner,
admin, or non-archived recipient) to mirror server auth.
- Socket handler for note_checklist_changed invalidates relevant
query keys AND patches the open popup payload directly via a new
IncomingNotePopupContext.updateChecklistItems action so
collaborators' open popups stay in sync.
Meeting alert animation parity (upcoming-meeting-alert.tsx)
- Added scale-95 -> scale-100 + fade entrance with the same spring
cubic-bezier the note popup uses, retriggered per eligible meeting.
- Replaced the 1px border with a ring-4 colored frame driven by
alertPrefs.accent (via boxShadow so the color is dynamic).
- Added an animate-ping accent halo around the drag-handle icon to
match the popup's avatar pulse.
Tests
- artifacts/api-server/tests/notes-checklist-toggle.test.mjs (7 tests:
owner/recipient toggle + mirroring, 403 non-recipient, 403
archived, 400 non-checklist, 404 unknown item, 400 invalid body).
- artifacts/tx-os/tests/notes-popup-checklist-collab.spec.mjs (e2e:
recipient ticks an item from the popup, server + sender snapshot
both reflect the change).
Code review (architect) findings addressed:
- (critical) lost-update race -> tx with row lock.
- (critical) non-atomic snapshot mirror -> same tx.
- (critical) open popup didn't re-render on socket fanout ->
updateChecklistItems context action.
- UI permission parity for archived recipients -> thread gates
onToggle.
Backend
- New POST /notes/:id/checklist/:itemId/toggle endpoint. Owner or any
active (non-archived) recipient can flip an item's done flag.
- Wrapped in a DB transaction with SELECT ... FOR UPDATE on the live
note row so concurrent toggles from multiple collaborators can't
lose each other's updates. Live notes.items + every
note_recipients.items snapshot are mirrored atomically in the same
tx.
- Emits note_checklist_changed to the audience minus the actor with
the full updated items array so receivers can patch state without
an extra fetch.
Frontend
- useToggleChecklistItem mutation hook with optimistic updates across
notes/sent/received/thread caches and rollback on error.
- Incoming-note popup checklist is now interactive with a local
override for instant visual feedback (popup renders from socket
payload, not from the query cache).
- Thread checklist toggles are gated by effective permission (owner,
admin, or non-archived recipient) to mirror server auth.
- Socket handler for note_checklist_changed invalidates relevant
query keys AND patches the open popup payload directly via a new
IncomingNotePopupContext.updateChecklistItems action so
collaborators' open popups stay in sync.
Meeting alert animation parity (upcoming-meeting-alert.tsx)
- Added scale-95 -> scale-100 + fade entrance with the same spring
cubic-bezier the note popup uses, retriggered per eligible meeting.
- Replaced the 1px border with a ring-4 colored frame driven by
alertPrefs.accent (via boxShadow so the color is dynamic).
- Added an animate-ping accent halo around the drag-handle icon to
match the popup's avatar pulse.
Tests
- artifacts/api-server/tests/notes-checklist-toggle.test.mjs (7 tests:
owner/recipient toggle + mirroring, 403 non-recipient, 403
archived, 400 non-checklist, 404 unknown item, 400 invalid body).
- artifacts/tx-os/tests/notes-popup-checklist-collab.spec.mjs (e2e:
recipient ticks an item from the popup, server + sender snapshot
both reflect the change).
Code review (architect) findings addressed:
- (critical) lost-update race -> tx with row lock.
- (critical) non-atomic snapshot mirror -> same tx.
- (critical) open popup didn't re-render on socket fanout ->
updateChecklistItems context action.
- UI permission parity for archived recipients -> thread gates
onToggle.
Backend
- New POST /notes/:id/checklist/:itemId/toggle endpoint. Owner or any
active (non-archived) recipient can flip an item's done flag.
- Wrapped in a DB transaction with SELECT ... FOR UPDATE on the live
note row so concurrent toggles from multiple collaborators can't
lose each other's updates. Live notes.items + every
note_recipients.items snapshot are mirrored atomically in the same
tx.
- Emits note_checklist_changed to the audience minus the actor with
the full updated items array so receivers can patch state without
an extra fetch.
Frontend
- useToggleChecklistItem mutation hook with optimistic updates across
notes/sent/received/thread caches and rollback on error.
- Incoming-note popup checklist is now interactive with a local
override for instant visual feedback (popup renders from socket
payload, not from the query cache).
- Thread checklist toggles are gated by effective permission (owner,
admin, or non-archived recipient) to mirror server auth.
- Socket handler for note_checklist_changed invalidates relevant
query keys AND patches the open popup payload directly via a new
IncomingNotePopupContext.updateChecklistItems action so
collaborators' open popups stay in sync.
Meeting alert animation parity (upcoming-meeting-alert.tsx)
- Added scale-95 -> scale-100 + fade entrance with the same spring
cubic-bezier the note popup uses, retriggered per eligible meeting.
- Replaced the 1px border with a ring-4 colored frame driven by
alertPrefs.accent (via boxShadow so the color is dynamic).
- Added an animate-ping accent halo around the drag-handle icon to
match the popup's avatar pulse.
Tests
- artifacts/api-server/tests/notes-checklist-toggle.test.mjs (7 tests:
owner/recipient toggle + mirroring, 403 non-recipient, 403
archived, 400 non-checklist, 404 unknown item, 400 invalid body).
- artifacts/tx-os/tests/notes-popup-checklist-collab.spec.mjs (e2e:
recipient ticks an item from the popup, server + sender snapshot
both reflect the change).
Code review (architect) findings addressed:
- (critical) lost-update race -> tx with row lock.
- (critical) non-atomic snapshot mirror -> same tx.
- (critical) open popup didn't re-render on socket fanout ->
updateChecklistItems context action.
- UI permission parity for archived recipients -> thread gates
onToggle.
Previously POST /api/notes/:id/send used onConflictDoNothing on
(noteId, recipientUserId) and only iterated `inserted` rows for
side-effects, so a re-send to the same recipient was silent — no
note_received socket event, no notification — even though the API
returned 200. Reported by the user: "I sent again to rh, why
didn't it reach them?"
Fix: after the idempotent insert, load the existing recipient
rows for any recipients that were skipped, and run the
notification + socket emit loop over BOTH inserted and existing
rows. The DB row is still not duplicated (snapshot semantics
preserved), but the recipient now sees the popup and gets a fresh
notification on every re-send.
Verified:
- @workspace/api-server tests/notes-share.test.mjs — 12/12 pass
(including "re-sending to the same recipient does not duplicate
the recipient row").
- tx-os e2e notes-popup-on-receive — 3/3 pass.
The popup was a colored body sitting inside a white frame; users
wanted the WHOLE popup to look like the sticky note itself, with
only the outer ring + chrome remaining as frame.
- Outer rounded-2xl card now uses `colorBg(current.color)` directly
(replacing `bg-background`). Default-color notes still render on
`bg-white dark:bg-card` so the look is unchanged for uncolored
notes.
- Removed the inner card-in-card colored body wrapper; title +
content/checklist now render directly on the tinted surface.
- Header divider switched from `bg-muted/40` (opaque chrome) to a
translucent `border-black/10 dark:border-white/10` so the tint
flows under the avatar/title/X without an opaque strip.
- Action row moved into its own bordered footer strip (same
translucent divider) so the 3 buttons stay legible on every
palette tint while letting the colored surface bleed through.
- Added `data-popup-color` on the card for diagnostics.
- Reply popups inherit the same tint via the existing `color` field
on the reply payload (no plumbing change).
No payload, locale, or test-id changes. All popup e2e suites pass:
notes-popup-on-receive (3/3), notes-popup-touch-tap (2/2).
The popup was a colored body sitting inside a white frame; users
wanted the WHOLE popup to look like the sticky note itself, with
only the outer ring + chrome remaining as frame.
- Outer rounded-2xl card now uses `colorBg(current.color)` directly
(replacing `bg-background`). Default-color notes still render on
`bg-white dark:bg-card` so the look is unchanged for uncolored
notes.
- Removed the inner card-in-card colored body wrapper; title +
content/checklist now render directly on the tinted surface.
- Header divider switched from `bg-muted/40` (opaque chrome) to a
translucent `border-black/10 dark:border-white/10` so the tint
flows under the avatar/title/X without an opaque strip.
- Action row moved into its own bordered footer strip (same
translucent divider) so the 3 buttons stay legible on every
palette tint while letting the colored surface bleed through.
- Added `data-popup-color` on the card for diagnostics.
- Reply popups inherit the same tint via the existing `color` field
on the reply payload (no plumbing change).
No payload, locale, or test-id changes. All popup e2e suites pass:
notes-popup-on-receive (3/3), notes-popup-touch-tap (2/2).
- Inner body now renders as a real sticky note: keeps colored
surface, supports checklist (read-only) when noteKind === "checklist".
- Action row trimmed to exactly 3 buttons: Done (تم), Open note
(فتح الملاحظة), Reply (رد). Removed the standalone Dismiss button;
header X still closes.
- Reply variant uses the same 3-button row (Done is a dismiss-only
no-op since the note owner can't mark their own note read).
- Wire kind + items from backend `note_received` payload into client
IncomingNotePayload (noteKind/items) via use-notifications-socket.
- Locales: markRead → "Done"/"تم"; new openNote/done keys; openThread
unified to "Open note"/"فتح الملاحظة".
- Tests: replaced removed `incoming-note-popup-dismiss` testid usages
with header `-close`; updated reply variant assertions to expect the
3-button row; fixed pre-existing pluralization bug in reply path
(`/replies` → `/reply`) that was unrelated to this task but blocked
the reply popup test from validating.
Labels and pin were not surfaced in the popup because they are
sender-private state (note_recipients only snapshots
title/content/color/kind/items); the recipient never receives the
sender's labelIds/isPinned, so showing them would be misleading.
Added a new e2e ("recipient popup renders checklist items for a
checklist note") that composes a checklist note via the UI, sends it,
and asserts `incoming-note-popup-checklist` is visible with both
items — locks in the noteKind/items socket plumbing.
All affected e2e tests pass (notes-popup-on-receive note + reply +
checklist, notes-popup-touch-tap both, notes-inbox); queue unit
tests pass.
- Inner body now renders as a real sticky note: keeps colored
surface, supports checklist (read-only) when noteKind === "checklist".
- Action row trimmed to exactly 3 buttons: Done (تم), Open note
(فتح الملاحظة), Reply (رد). Removed the standalone Dismiss button;
header X still closes.
- Reply variant uses the same 3-button row (Done is a dismiss-only
no-op since the note owner can't mark their own note read).
- Wire kind + items from backend `note_received` payload into client
IncomingNotePayload (noteKind/items) via use-notifications-socket.
- Locales: markRead → "Done"/"تم"; new openNote/done keys; openThread
unified to "Open note"/"فتح الملاحظة".
- Tests: replaced removed `incoming-note-popup-dismiss` testid usages
with header `-close`; updated reply variant assertions to expect the
3-button row; fixed pre-existing pluralization bug in reply path
(`/replies` → `/reply`) that was unrelated to this task but blocked
the reply popup test from validating.
Labels and pin were not surfaced in the popup because they are
sender-private state (note_recipients only snapshots
title/content/color/kind/items); the recipient never receives the
sender's labelIds/isPinned, so showing them would be misleading.
Added a new e2e ("recipient popup renders checklist items for a
checklist note") that composes a checklist note via the UI, sends it,
and asserts `incoming-note-popup-checklist` is visible with both
items — locks in the noteKind/items socket plumbing.
All affected e2e tests pass (notes-popup-on-receive note + reply +
checklist, notes-popup-touch-tap both, notes-inbox); queue unit
tests pass.
- Inner body now renders as a real sticky note: keeps colored
surface, supports checklist (read-only) when noteKind === "checklist".
- Action row trimmed to exactly 3 buttons: Done (تم), Open note
(فتح الملاحظة), Reply (رد). Removed the standalone Dismiss button;
header X still closes.
- Reply variant uses the same 3-button row (Done is a dismiss-only
no-op since the note owner can't mark their own note read).
- Wire kind + items from backend `note_received` payload into client
IncomingNotePayload (noteKind/items) via use-notifications-socket.
- Locales: markRead → "Done"/"تم"; new openNote/done keys; openThread
unified to "Open note"/"فتح الملاحظة".
- Tests: replaced removed `incoming-note-popup-dismiss` testid usages
with header `-close`; updated reply variant assertions to expect the
3-button row; fixed pre-existing pluralization bug in reply path
(`/replies` → `/reply`) that was unrelated to this task but blocked
the reply popup test from validating.
Labels and pin were not surfaced in the popup because they are
sender-private state (note_recipients only snapshots
title/content/color/kind/items); the recipient never receives the
sender's labelIds/isPinned, so showing them would be misleading.
Added a new e2e ("recipient popup renders checklist items for a
checklist note") that composes a checklist note via the UI, sends it,
and asserts `incoming-note-popup-checklist` is visible with both
items — locks in the noteKind/items socket plumbing.
All affected e2e tests pass (notes-popup-on-receive note + reply +
checklist, notes-popup-touch-tap both, notes-inbox); queue unit
tests pass.
- Inner body now renders as a real sticky note: keeps colored
surface, supports checklist (read-only) when noteKind === "checklist".
- Action row trimmed to exactly 3 buttons: Done (تم), Open note
(فتح الملاحظة), Reply (رد). Removed the standalone Dismiss button;
header X still closes.
- Reply variant uses the same 3-button row (Done is a dismiss-only
no-op since the note owner can't mark their own note read).
- Wire kind + items from backend `note_received` payload into client
IncomingNotePayload (noteKind/items) via use-notifications-socket.
- Locales: markRead → "Done"/"تم"; new openNote/done keys; openThread
unified to "Open note"/"فتح الملاحظة".
- Tests: replaced removed `incoming-note-popup-dismiss` testid usages
with header `-close`; updated reply variant assertions to expect the
3-button row; fixed pre-existing pluralization bug in reply path
(`/replies` → `/reply`) that was unrelated to this task but blocked
the reply popup test from validating.
Labels and pin were not surfaced in the popup because they are
sender-private state (note_recipients only snapshots
title/content/color/kind/items); the recipient never receives the
sender's labelIds/isPinned, so showing them would be misleading.
All affected e2e tests pass (notes-popup-on-receive note + reply,
notes-popup-touch-tap both, notes-inbox); queue unit tests pass.
Two visual issues in the "إرسال الملاحظة" dialog:
1. The shadcn DialogContent renders a built-in close (X) button hard
pinned at `right-4 top-4`. In Arabic the dialog title is
right-aligned and crashed into the X.
Fix: add `pr-8` to the SendNoteDialog header so the title row
reserves physical right-padding matching where the X actually
lives in both LTR and RTL. (Initially used `pe-8` but corrected to
`pr-8` after code review noted the close button is pinned with
physical `right-4`, so a logical end-padding flips to the wrong
side in RTL.) The shared dialog component is unchanged so other
dialogs are untouched (out of scope per the task plan).
2. The recipient search field used inline `style={{ right|left: 10 }}`
for the magnifier and a conditional `pe-9` / `ps-9` based on
`i18n.language`. In RTL the icon collided with the placeholder.
Fix: drop the conditional branching — position the icon with the
logical class `start-2.5` and always pad the input with `ps-9`.
The icon now sits at the inline-start edge in both LTR and RTL
with a clear gutter to the placeholder/caret.
Skipped step 3 of the plan (i18n aria-label override on the X). It
required no locale changes and no rendering improvement, so per the
plan's own conditional ("only if step 3 keeps the override; otherwise
no locale changes") it was dropped to keep scope tight.
Verification:
- `pnpm exec tsc --noEmit` clean.
- Playwright: `notes-inbox.spec.mjs` (1/1) and
`notes-popup-touch-tap.spec.mjs` (2/2) green — both exercise the
send-note dialog rendering. `notes-popup-on-receive.spec.mjs` runs
two browser contexts and exceeds the local 120s shell cap; not
re-run here, but the diff is CSS-only and cannot affect the wire
flow it covers.
Two visual issues in the "إرسال الملاحظة" dialog:
1. The shadcn DialogContent renders a built-in close (X) button hard
pinned at `right-4 top-4`. In Arabic the dialog title is
right-aligned and crashed into the X.
Fix: add `pe-8` to the SendNoteDialog header so the title row
reserves logical end-padding for the X in both directions. The
shared dialog component is unchanged so other dialogs are untouched
(out of scope per the task plan).
2. The recipient search field used inline `style={{ right|left: 10 }}`
for the magnifier and a conditional `pe-9` / `ps-9` based on
`i18n.language`. In RTL the icon collided with the placeholder.
Fix: drop the conditional branching — position the icon with the
logical class `start-2.5` and always pad the input with `ps-9`.
The icon now sits at the inline-start edge in both LTR and RTL
with a clear gutter to the placeholder/caret.
Skipped step 3 of the plan (i18n aria-label override on the X). It
required no locale changes and no rendering improvement, so per the
plan's own conditional ("only if step 3 keeps the override; otherwise
no locale changes") it was dropped to keep scope tight.
Verification:
- `pnpm exec tsc --noEmit` clean.
- Playwright: `notes-inbox.spec.mjs` (1/1) and
`notes-popup-touch-tap.spec.mjs` (2/2) green — both exercise the
send-note dialog rendering. `notes-popup-on-receive.spec.mjs` runs
two browser contexts and exceeds the local 120s shell cap; not
re-run here, but the diff is CSS-only and cannot affect the wire
flow it covers.
Fixes two regressions surfaced after the folder browser shipped in #429:
1. Note created from inside a folder went to Unfiled
- Composer now takes `folderSelection` and resolves the target folder:
`folder` → that id, `unfiled`/`all` → null. The new note appears in
the active folder view immediately and the folder count increments
via the existing notes query invalidation.
2. No in-app back from a folder view
- Added a "← Back to folders / المجلدات" chip above the composer
whenever a folder or Unfiled is selected (active tab only). Tapping
it resets the selection to "all" and lands the user back on the
folders browser. The global header back button is unchanged.
- Chevron flips for RTL via `rtl:rotate-180`.
- Locale keys: `notes.folders.backToFolders` (EN/AR).
Verification:
- tsc --noEmit clean.
- Playwright suites all green: notes-folders, notes-checklist,
notes-card-touch-actions, notes-delete-confirm (8 tests).
- Notes restored to original sticky-note cards (Section + NoteCard) at all
views, reverting the file-manager-style note rendering from #427.
- Folders render as a file-manager browser at the top of the active "All
notes" view: black folder icon, name, relative time, item-count badge,
"…" kebab with rename/delete, and a checkbox for multi-select. Honors the
reused grid/list view-toggle.
- Multi-select bar appears when ≥1 folder is checked, with bulk Delete
(confirmation dialog) and Cancel actions. Bulk delete uses Promise.all
over useDeleteFolder; selection auto-prunes deleted ids.
- View-toggle is hidden when not at active+all (it now only governs the
folder browser).
- Added `mode: "rail" | "chips-only"` to FoldersRail. Chips-only is scoped
to active+all only — archived/inbox/sent rail behavior is unchanged.
- Drop targets preserved (data-folder-drop, folder-drop-${id}) so desktop
DnD and touch-long-press pipelines keep working.
- Click propagation stopped in DropdownMenuContent and around the checkbox
so menu/checkbox interactions don't navigate into the folder.
- Removed obsolete FilesView/FileItem/SelectionBar/DeleteDialog/colorTint
helpers (~650 lines).
- Added EN/AR locale keys: notes.folders.actions, renameFailed, itemCount,
itemCountOne, select, bulkSelected, bulkDeleteTitle, bulkDeleteConfirm,
bulkDeleteFailed.
- Verified: tsc --noEmit clean; notes-folders, notes-card-touch-actions,
notes-checklist, notes-delete-confirm Playwright suites all green.
Drift note: kept "All notes" as a mixed surface (folders browser + sticky
notes below the composer) per the user's task wording, which explicitly
requires both sticky-note cards and file-manager folders. Code reviewer
suggested folders-only as primary surface, but doing so would hide notes
the user explicitly asked to see and break tests at the default view.
- Notes restored to original sticky-note cards (Section + NoteCard) at all
views, reverting the file-manager-style note rendering from #427.
- Folders now render as a file-manager browser at the top of the "All notes"
view: black folder icon, name, relative time, item-count badge, "…" kebab
with rename/delete, plus a checkbox for multi-select.
- Multi-select bar appears when ≥1 folder is checked, with bulk Delete
(confirmation dialog) and Cancel actions. Bulk delete uses Promise.all
over useDeleteFolder; selection auto-prunes deleted ids.
- Grid/list view-toggle reused from #427; toggle is hidden when not at
"All notes" since it now only governs the folder browser.
- Added `mode: "rail" | "chips-only"` to FoldersRail. At "All notes" the
rail switches to chips-only (All / Unfiled / + New folder) so folder rows
live exclusively in the new browser and test ids never collide.
- Drop targets preserved (data-folder-drop, folder-drop-${id}) so the
desktop DnD and touch-long-press pipelines keep working.
- Stop click propagation in DropdownMenuContent and around the checkbox to
prevent rename/delete/checkbox clicks from navigating into the folder.
- Removed obsolete FilesView/FileItem/SelectionBar/DeleteDialog/colorTint
helpers (~650 lines).
- Added EN/AR locale keys: notes.folders.actions, renameFailed, itemCount,
itemCountOne, select, bulkSelected, bulkDeleteTitle, bulkDeleteConfirm,
bulkDeleteFailed.
- Verified: tsc --noEmit clean; all 8 tests in notes-folders,
notes-card-touch-actions, notes-checklist, notes-delete-confirm pass.
- Notes reverted to original sticky-note cards (Section + NoteCard) at all
views, removing the file-manager-style note rendering from task #427.
- Folders now render as a file-manager browser at the top of the "All notes"
view: big black folder icon, name, relative time, item-count badge, and a
"…" kebab with rename/delete. Grid and list layouts honor the existing
view-toggle, plus a "{{count}} folders" footer.
- Added `mode: "rail" | "chips-only"` prop to FoldersRail. At "all" view the
rail switches to chips-only (All / Unfiled / + New folder) so folder rows
live exclusively in the new browser and test ids never collide.
- View-toggle is now hidden when not at "all" (folders-only control).
- New FoldersBrowser/FolderItem reuse useUpdateFolder/useDeleteFolder, set
data-folder-drop for the touch DnD pipeline, and stop click propagation
inside the dropdown so rename/delete don't navigate the card.
- Added locale keys: notes.folders.actions/renameFailed/itemCount(One).
- Removed obsolete FilesView/FileItem/SelectionBar/DeleteDialog/colorTint
helpers (~650 lines).
- Verified: tsc --noEmit clean; notes-folders, notes-card-touch-actions,
notes-checklist, notes-delete-confirm Playwright suites all green.
Root cause on iOS Safari (iPad/phone): the `IncomingNotePopup`
rendered a `fixed inset-0 z-[110]` full-viewport wrapper. Stacking
that layer on top of the upcoming-meeting alert plus a Radix toast
intermittently caused the next finger tap to be swallowed — the user
saw the popup "hang". A simultaneous re-render storm from
synchronous query invalidations on multi-event socket fanouts made
it worse on slower hardware.
Fixes:
- Drop the full-viewport wrapper: render the popup card directly
as a sized `fixed` element. No more invisible viewport-sized
layer between touch and the rest of the UI.
- Suppress the redundant note/reply toast when the floating
popup actually accepts the event. The popup IS the surface;
doubling up just stacks one more floating layer.
- Remove `autoFocus` on the Reply button — focus-steal was
contributing to the perceived hang.
- Coalesce `react-query` `invalidateQueries` calls in the
notifications socket: collect into a Set and flush once per
animation frame so a burst of socket events triggers a single
refetch pass instead of N synchronous re-renders. Cleaned up
on socket disconnect.
Tests (artifacts/tx-os/tests/notes-popup-touch-tap.spec.mjs):
- "recipient on a touch device can tap Reply on the floating
note popup" — verifies the popup is no longer viewport-sized,
the duplicate toast is suppressed, and a real `locator.tap()`
succeeds.
- "popup + meeting alert simultaneously: tap on popup still
works" — the user's exact scenario: seeds an imminent meeting
so the alert appears, triggers a real cross-user note
delivery so both float simultaneously, then taps Reply on
the popup and confirms it dismisses while the alert remains.
Both tests + tsc --noEmit clean.
Files:
- artifacts/tx-os/src/components/notes/incoming-note-popup.tsx
- artifacts/tx-os/src/hooks/use-notifications-socket.ts
- artifacts/tx-os/tests/notes-popup-touch-tap.spec.mjs (new)
Root cause on iOS Safari (iPad/phone): the `IncomingNotePopup`
rendered a `fixed inset-0 z-[110]` full-viewport wrapper with
`pointer-events-none`. Stacking that layer on top of the upcoming
meeting alert plus a Radix toast intermittently caused the next
finger tap to be swallowed — the user saw the popup "hang".
Fixes:
- Drop the full-viewport wrapper: render the popup card directly
as a sized `fixed` element. No more invisible viewport-sized
layer between touch and the rest of the UI.
- Suppress the redundant note/reply toast when the floating
popup actually accepts the event. The popup IS the surface;
doubling up just stacks one more floating layer.
- Remove `autoFocus` on the Reply button. A new popup arriving
while the user is mid-tap would steal focus, contributing to
the perceived hang.
Tests:
- New `notes-popup-touch-tap.spec.mjs`: emulates a touch viewport,
sends a real cross-user note, verifies popup bounding box is
card-sized (not viewport-sized), the redundant toast is
suppressed, and a `locator.tap()` on Reply dismisses the
popup and navigates.
- `tsc --noEmit` clean.
Files:
- artifacts/tx-os/src/components/notes/incoming-note-popup.tsx
- artifacts/tx-os/src/hooks/use-notifications-socket.ts
- artifacts/tx-os/tests/notes-popup-touch-tap.spec.mjs (new)
riyadhafraa