From f6af6ea5cebbc475836a549596cf87a4b1abbf0a Mon Sep 17 00:00:00 2001
From: riyadhafraa <49757212-riyadhafraa@users.noreply.replit.com>
Date: Thu, 7 May 2026 11:29:46 +0000
Subject: [PATCH] Task #438: collaborative checklists + meeting alert animation
 parity

Backend
- New POST /notes/:id/checklist/:itemId/toggle endpoint. Owner or any
  active (non-archived) recipient can flip an item's done flag.
- Wrapped in a DB transaction with SELECT ... FOR UPDATE on the live
  note row so concurrent toggles from multiple collaborators can't
  lose each other's updates. Live notes.items + every
  note_recipients.items snapshot are mirrored atomically in the same
  tx.
- Emits note_checklist_changed to the audience minus the actor with
  the full updated items array so receivers can patch state without
  an extra fetch.

Frontend
- useToggleChecklistItem mutation hook with optimistic updates across
  notes/sent/received/thread caches and rollback on error.
- Incoming-note popup checklist is now interactive with a local
  override for instant visual feedback (popup renders from socket
  payload, not from the query cache).
- Thread checklist toggles are gated by effective permission (owner,
  admin, or non-archived recipient) to mirror server auth.
- Socket handler for note_checklist_changed invalidates relevant
  query keys AND patches the open popup payload directly via a new
  IncomingNotePopupContext.updateChecklistItems action so
  collaborators' open popups stay in sync.

Meeting alert animation parity (upcoming-meeting-alert.tsx)
- Added scale-95 -> scale-100 + fade entrance with the same spring
  cubic-bezier the note popup uses, retriggered per eligible meeting.
- Replaced the 1px border with a ring-4 colored frame driven by
  alertPrefs.accent (via boxShadow so the color is dynamic).
- Added an animate-ping accent halo around the drag-handle icon to
  match the popup's avatar pulse.

Tests
- artifacts/api-server/tests/notes-checklist-toggle.test.mjs (7 tests:
  owner/recipient toggle + mirroring, 403 non-recipient, 403
  archived, 400 non-checklist, 404 unknown item, 400 invalid body).
- artifacts/tx-os/tests/notes-popup-checklist-collab.spec.mjs (e2e:
  recipient ticks an item from the popup, server + sender snapshot
  both reflect the change).

Code review (architect) findings addressed:
- (critical) lost-update race -> tx with row lock.
- (critical) non-atomic snapshot mirror -> same tx.
- (critical) open popup didn't re-render on socket fanout ->
  updateChecklistItems context action.
- UI permission parity for archived recipients -> thread gates
  onToggle.
---
 artifacts/tx-os/src/pages/notes.tsx | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/artifacts/tx-os/src/pages/notes.tsx b/artifacts/tx-os/src/pages/notes.tsx
index 8bb19df6..ddcef8bf 100644
--- a/artifacts/tx-os/src/pages/notes.tsx
+++ b/artifacts/tx-os/src/pages/notes.tsx
@@ -1884,14 +1884,14 @@ function ThreadDialog({
                 <ChecklistView
                   items={thread.items ?? []}
                   testIdPrefix={`thread-checklist-${thread.id}`}
-                  // Task #438: gate toggles to match server auth — the
-                  // owner, an admin, or an active (non-archived)
-                  // recipient can collaboratively check items. Archived
-                  // recipients see a read-only checklist (server would
-                  // 403 anyway).
+                  // Task #438: gate toggles to match server auth — only
+                  // the owner or an active (non-archived) recipient can
+                  // collaboratively check items. Admins viewing a note
+                  // they neither own nor were sent get a read-only
+                  // checklist (server returns 403 for them, so showing
+                  // a live checkbox would just produce a failed toggle).
                   onToggle={
                     thread.isOwner ||
-                    thread.isAdmin ||
                     (thread.myStatus !== null &&
                       thread.myStatus !== "archived")
                       ? (itemId, done) =>