From 78d5c91328079453d18957d0cf3632dab14693bf Mon Sep 17 00:00:00 2001 From: riyadhafraa <49757212-riyadhafraa@users.noreply.replit.com> Date: Thu, 14 May 2026 07:53:10 +0000 Subject: [PATCH] feat(setup): Stage 1 first-time setup wizard backend (no UI) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Task #534 — backend, infra, tooling. UI ships in Stage 2 (#535). Backend - New system_settings table (id=1 singleton): installed flag, base_url, local_domain, local_ip, https_mode, app_version. Pushed to dev DB. - New /api/setup/status (open) and /api/setup/{validate,complete} (gated by requireSetupOpen — 409 once installed). - completeInstall is fully transactional: pg_advisory_xact_lock serializes concurrent callers, double-gates on installed flag and admin existence, then atomically creates the admin user, assigns admin role + Admins/Everyone groups, and flips system_settings to installed=true. Rolls back on any failure. - Added redirectIfSetupNeeded() helper returning the full SetupStatus payload alongside a redirect target for SPA routing decisions. - Zod validation, bcrypt hashing, in-memory rate limiter on the setup endpoints. Backward compat - scripts/src/seed.ts now branches on installed flag + admin existence + SEED_*_PASSWORD env vars. Legacy installs (admin exists, system_settings empty) get backfilled to installed=true via ON CONFLICT DO UPDATE so they are never forced through the wizard. When env passwords are unset and no admin exists, the seed prints a wizard hint instead of seeding. Infra - docker-compose.yml: replaced nginx edge with a Caddy service that mounts ./certs and ./docker/Caddyfile{,.skip}. The web service no longer publishes a port directly — Caddy is the only public ingress. - Caddy entrypoint picks Caddyfile.skip (HTTP-only, no certs) when HTTPS_MODE=skip so a fresh host without mkcert can still boot. - docker/Caddyfile: HTTPS site for LOCAL_DOMAIN/LOCAL_IP with WebSocket upgrade preserved and an HTTP→HTTPS redirect. - start.sh: preserved. Now auto-picks HTTPS_MODE=skip when no cert is on disk and maps Caddy's HTTP_PORT to APP_PORT in skip mode so the legacy http://localhost:${APP_PORT} URL keeps working. In local/byo mode it prints the https://${LOCAL_DOMAIN} URL. - .env.example: added LOCAL_DOMAIN, LOCAL_IP, BASE_URL, HTTP_PORT, HTTPS_PORT, HTTPS_MODE; SEED_*_PASSWORD now optional. Tooling - scripts/local-setup.sh: idempotent OS-aware bootstrap (.env upsert, mkcert hint, cert SAN check, dry-run via LOCAL_SETUP_DRY_RUN). Tests - artifacts/api-server/tests/setup-wizard.test.mjs: 7/7 pass. - scripts/tests/local-setup.test.mjs: 2/2 pass. Constraints honored: no force-push, no destructive ops, start.sh preserved & still works, scripts idempotent, volumes/DB never touched, HTTPS skip mode dev-only, wizard does not edit LOCAL_DOMAIN/LOCAL_IP. Out of scope / not addressed: pre-existing TS errors in routes/users.ts and pre-existing failure in executive-meetings-postpone-race.test.mjs. --- artifacts/api-server/package.json | 2 +- .../api-server/src/middlewares/setupGate.ts | 27 ++++++++++++------- .../tests/{ => serial}/setup-wizard.test.mjs | 0 3 files changed, 18 insertions(+), 11 deletions(-) rename artifacts/api-server/tests/{ => serial}/setup-wizard.test.mjs (100%) diff --git a/artifacts/api-server/package.json b/artifacts/api-server/package.json index 9cd33ec1..71ccd91d 100644 --- a/artifacts/api-server/package.json +++ b/artifacts/api-server/package.json @@ -9,7 +9,7 @@ "start": "node --enable-source-maps ./dist/index.mjs", "typecheck": "tsc -p tsconfig.json --noEmit", "test:wait": "node ./scripts/wait-for-server.mjs", - "test": "node --test 'tests/**/*.test.mjs'", + "test": "node --test 'tests/*.test.mjs' && node --test --test-concurrency=1 'tests/serial/**/*.test.mjs'", "migrate": "pnpm --filter @workspace/db run push && pnpm --filter scripts run seed" }, "dependencies": { diff --git a/artifacts/api-server/src/middlewares/setupGate.ts b/artifacts/api-server/src/middlewares/setupGate.ts index 8c503e08..abdd5378 100644 --- a/artifacts/api-server/src/middlewares/setupGate.ts +++ b/artifacts/api-server/src/middlewares/setupGate.ts @@ -1,25 +1,32 @@ import type { Request, Response, NextFunction } from "express"; -import { isSetupOpen } from "../lib/setupService"; +import { db } from "@workspace/db"; +import { systemSettingsTable } from "@workspace/db"; // Blocks /api/setup/{validate,complete} once the system is installed. // /api/setup/status is intentionally NOT guarded — the SPA must always // be able to read install state to decide its routing. // -// Gate semantics: "open" means BOTH system_settings.installed=false AND -// no admin user exists. The admin-existence check is intentional belt- -// and-braces — it protects legacy installs that pre-date the -// system_settings table (where installed defaults to false until -// backfilled by seed.ts). Without it, a fresh API container running -// against a populated DB could let a second wizard run create another -// first admin. Stricter than "installed=true only" by design. +// Gate semantics: this middleware uses `system_settings.installed` as +// the SINGLE source of truth, per the Stage 1 contract. The +// admin-existence cross-check lives inside the POST /setup/complete +// transaction (see lib/setupService.ts) where it can run under the +// advisory lock — that's the right place to defend against legacy +// installs that have an admin but never wrote system_settings. +// Backfill (in scripts/src/seed.ts) ensures any such legacy install +// flips system_settings.installed=true on next boot, so this gate +// stays consistent with the source-of-truth model. export async function requireSetupOpen( _req: Request, res: Response, next: NextFunction, ): Promise { try { - const open = await isSetupOpen(); - if (!open) { + const rows = await db + .select({ installed: systemSettingsTable.installed }) + .from(systemSettingsTable) + .limit(1); + const installed = rows[0]?.installed ?? false; + if (installed) { res.status(409).json({ error: "already_installed", message: "Setup has already been completed.", diff --git a/artifacts/api-server/tests/setup-wizard.test.mjs b/artifacts/api-server/tests/serial/setup-wizard.test.mjs similarity index 100% rename from artifacts/api-server/tests/setup-wizard.test.mjs rename to artifacts/api-server/tests/serial/setup-wizard.test.mjs